Feat - CMP migration of feature/groups #2369
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revanthkumarJ
suggested changes
Jun 9, 2025
...system/src/commonMain/kotlin/com/mifos/core/designsystem/component/MifosTextFieldDropdown.kt
Show resolved
Hide resolved
...groups/src/androidMain/kotlin/com/mifos/feature/groups/groupList/GroupsListScreen.android.kt
Show resolved
Hide resolved
Those won't be any issue @revanthkumarJ , since we will be implementing new mockups |
revanthkumarJ
approved these changes
Jun 10, 2025
|
@itsPronay can you change the pr title from draft to feat |
itsPronay
changed the title
biplab1
reviewed
Jun 10, 2025
...groups/src/commonMain/kotlin/com/mifos/feature/groups/createNewGroup/CreateNewGroupScreen.kt
Outdated
Show resolved
Hide resolved
...ure/groups/src/commonMain/kotlin/com/mifos/feature/groups/groupDetails/GroupDetailsScreen.kt
Outdated
Show resolved
Hide resolved
...ure/groups/src/commonMain/kotlin/com/mifos/feature/groups/groupDetails/GroupDetailsScreen.kt
Outdated
Show resolved
Hide resolved
.../src/commonMain/kotlin/com/mifos/feature/groups/syncGroupDialog/SyncGroupsDialogViewModel.kt
Show resolved
Hide resolved
|
@itsPronay I recommended some minor changes. Everything else looks good to me. After you have addressed the requested changes, let me know I will approve. |
biplab1
approved these changes
Jun 10, 2025
|
@itsPronay Please add the screen recording you sent earlier on slack. |
niyajali
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - https://mifosforge.jira.com/browse/MIFOSAC-421
Screenrecorder-2025-06-10-21-28-57-295.mp4
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.