feat : Center migrated to CMP #2391
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cmp-navigation/src/commonMain/kotlin/cmp/navigation/navigation/FeatureNavHost.kt
# Conflicts: # cmp-navigation/build.gradle.kts # cmp-navigation/src/commonMain/kotlin/cmp/navigation/di/KoinModules.kt # cmp-navigation/src/commonMain/kotlin/cmp/navigation/navigation/FeatureNavHost.kt # core/designsystem/src/commonMain/kotlin/com/mifos/core/designsystem/component/MifosTextFieldDropdown.kt # settings.gradle.kts
biplab1
reviewed
Jun 8, 2025
cmp-navigation/src/commonMain/kotlin/cmp/navigation/navigation/FeatureNavHost.kt
Show resolved
Hide resolved
...nter/src/nativeMain/kotlin/com/mifos/feature/center/centerList/ui/CenterListScreen.native.kt
Outdated
Show resolved
Hide resolved
feature/center/src/commonMain/kotlin/com/mifos/feature/center/centerList/ui/CenterListScreen.kt
Outdated
Show resolved
Hide resolved
feature/center/src/commonMain/kotlin/com/mifos/feature/center/centerList/ui/CenterListScreen.kt
Outdated
Show resolved
Hide resolved
biplab1
reviewed
Jun 8, 2025
...er/src/androidMain/kotlin/com/mifos/feature/center/centerList/ui/CenterListScreen.android.kt
Outdated
Show resolved
Hide resolved
|
@revanthkumarJ Once you've addressed all the requested changes, I'll go ahead and approve it. |
biplab1
approved these changes
Jun 8, 2025
|
@therajanmaurya @niyajali done the required changes told by reviewers can you do final review and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-415
WhatsApp.Video.2025-06-08.at.2.47.00.PM.mp4