Report migrate to cmp #2392
Merged
Report migrate to cmp #2392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...system/src/commonMain/kotlin/com/mifos/core/designsystem/component/MifosTextFieldDropdown.kt
Outdated
Show resolved
Hide resolved
feature/report/src/commonMain/kotlin/com/mifos/feature/report/report/ReportScreen.kt
Outdated
Show resolved
Hide resolved
feature/report/src/commonMain/kotlin/com/mifos/feature/report/report/ReportViewModel.kt
Outdated
Show resolved
Hide resolved
.../report/src/commonMain/kotlin/com/mifos/feature/report/reportDetail/ReportDetailViewModel.kt
Outdated
Show resolved
Hide resolved
revanthkumarJ
suggested changes
Jun 6, 2025
There was a problem hiding this comment.
@kapmaurya don't add anything to libs.toml i think every required thing is added already,
if in any particul;ar case you are using any different librarie for kmp include it only.
Remove auto generated wild card <*>
Don't comment previews
feature/report/src/commonMain/kotlin/com/mifos/feature/report/report/ReportScreen.kt
Outdated
Show resolved
Hide resolved
...ure/report/src/commonMain/kotlin/com/mifos/feature/report/reportDetail/ReportDetailScreen.kt
Outdated
Show resolved
Hide resolved
.../report/src/commonMain/kotlin/com/mifos/feature/report/reportDetail/ReportDetailViewModel.kt
Outdated
Show resolved
Hide resolved
|
@kapmaurya status of this? |
# Conflicts: # cmp-navigation/src/commonMain/kotlin/cmp/navigation/di/KoinModules.kt # core/designsystem/src/commonMain/kotlin/com/mifos/core/designsystem/component/MifosTextFieldDropdown.kt # settings.gradle.kts
# Conflicts: # cmp-navigation/src/commonMain/kotlin/cmp/navigation/di/KoinModules.kt # core/designsystem/src/commonMain/kotlin/com/mifos/core/designsystem/component/MifosTextFieldDropdown.kt # settings.gradle.kts
# Conflicts: # cmp-navigation/src/commonMain/kotlin/cmp/navigation/di/KoinModules.kt
# Conflicts: # cmp-navigation/src/commonMain/kotlin/cmp/navigation/navigation/FeatureNavHost.kt
WhatsApp.Video.2025-06-22.at.12.44.20.PM.mp4 |
revanthkumarJ
approved these changes
Jun 22, 2025
|
Permission box when user first time exporting csv WhatsApp.Video.2025-06-22.at.4.09.27.PM.mp4 |
WhatsApp.Video.2025-06-22.at.4.27.20.PM.mp4 |
itsPronay
approved these changes
Jun 22, 2025
biplab1
reviewed
Jun 22, 2025
feature/report/src/commonMain/kotlin/com/mifos/feature/report/runReport/RunReportViewModel.kt
Outdated
Show resolved
Hide resolved
feature/report/src/commonMain/kotlin/com/mifos/feature/report/runReport/RunReportViewModel.kt
Show resolved
Hide resolved
feature/report/src/commonMain/kotlin/com/mifos/feature/report/runReport/RunReportViewModel.kt
Show resolved
Hide resolved
.../report/src/commonMain/kotlin/com/mifos/feature/report/reportDetail/ReportDetailViewModel.kt
Show resolved
Hide resolved
feature/report/src/commonMain/kotlin/com/mifos/feature/report/report/ReportScreen.kt
Outdated
Show resolved
Hide resolved
.../src/commonMain/kotlin/com/mifos/core/model/objects/runreport/client/ClientReportTypeItem.kt
Show resolved
Hide resolved
core/model/src/commonMain/kotlin/com/mifos/core/model/objects/runreport/DataRow.kt
Show resolved
Hide resolved
biplab1
approved these changes
Jun 23, 2025
niyajali
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#Issue_Number
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.