savings migration to CMP #2398
Merged
savings migration to CMP #2398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revanthkumarJ
suggested changes
Jun 7, 2025
...in/com/mifos/feature/savings/savingsAccountTransaction/SavingsAccountTransactionViewModel.kt
Show resolved
Hide resolved
|
@itsPronay also upload the screenshots |
i am currently unable to navigate as the previous screen hasnt been completed yet. I'll try a workaround ... |
niyajali
requested changes
Jun 7, 2025
...ngs/src/commonMain/kotlin/com/mifos/feature/savings/savingsAccount/SavingAccountViewModel.kt
Outdated
Show resolved
Hide resolved
...ngs/src/commonMain/kotlin/com/mifos/feature/savings/savingsAccount/SavingAccountViewModel.kt
Show resolved
Hide resolved
|
@itsPronay, Resolve merge conflicts and ask team members for approval |
revanthkumarJ
suggested changes
Jun 9, 2025
...Main/kotlin/com/mifos/feature/savings/savingsAccountActivate/SavingsAccountActivateScreen.kt
Show resolved
Hide resolved
...Main/kotlin/com/mifos/feature/savings/savingsAccountActivate/SavingsAccountActivateScreen.kt
Show resolved
Hide resolved
|
@itsPronay let me know after that changes i will approve this pr |
biplab1
reviewed
Jun 9, 2025
There was a problem hiding this comment.
You should address nullability before entering the LaunchedEffect block or handle the null case inside the block before calling the function. Do not use !! unless you are 100% certain the value cannot be null. I also noticed !! being used at other places also. Please review them to make sure the null cases are handled properly.
cmp-navigation/src/commonMain/kotlin/cmp/navigation/di/KoinModules.kt
Outdated
Show resolved
Hide resolved
...Main/kotlin/com/mifos/feature/savings/savingsAccountActivate/SavingsAccountActivateScreen.kt
Show resolved
Hide resolved
...Main/kotlin/com/mifos/feature/savings/savingsAccountApproval/SavingsAccountApprovalScreen.kt
Outdated
Show resolved
Hide resolved
...onMain/kotlin/com/mifos/feature/savings/savingsAccountSummary/SavingsAccountSummaryScreen.kt
Outdated
Show resolved
Hide resolved
...onMain/kotlin/com/mifos/feature/savings/savingsAccountSummary/SavingsAccountSummaryScreen.kt
Outdated
Show resolved
Hide resolved
...onMain/kotlin/com/mifos/feature/savings/savingsAccountSummary/SavingsAccountSummaryScreen.kt
Show resolved
Hide resolved
...onMain/kotlin/com/mifos/feature/savings/savingsAccountSummary/SavingsAccountSummaryScreen.kt
Show resolved
Hide resolved
...otlin/com/mifos/feature/savings/savingsAccountTransaction/SavingsAccountTransactionScreen.kt
Outdated
Show resolved
Hide resolved
|
@itsPronay Let me know once you’ve addressed the comments—I’ll approve it then. Also, I noticed several TODOs in the code. |
revanthkumarJ
approved these changes
Jun 9, 2025
biplab1
approved these changes
Jun 9, 2025
niyajali
approved these changes
Jun 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - https://mifosforge.jira.com/browse/MIFOSAC-427
Didn't create a Jira ticket, click here to create new.
Please Add Screenshots If there are any UI changes.
Please make sure these boxes are checked before submitting your pull request - thanks!
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.