refactor(feature:path-tracking): migrate to CMP #2400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns, navigation, typography
itsPronay
reviewed
Jun 7, 2025
...re/path-tracking/src/commonMain/kotlin/com/mifos/feature/path/tracking/PathTrackingScreen.kt
Show resolved
Hide resolved
|
@biplab1 Is it done? Please get approval from other team members. |
|
@niyajali I have requested approval from @itsPronay and @revanthkumarJ |
revanthkumarJ
approved these changes
Jun 8, 2025
itsPronay
approved these changes
Jun 8, 2025
niyajali
approved these changes
Jun 8, 2025
There was a problem hiding this comment.
We can enhance it more but I'm merging this now, and plan later for enhancement like instead of calling view model method inaide of LaunchEffect use init in ViewModel and call that method there, and use class(::) reference if the parameters are same instead of function call.and more
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#425
path_tracking_screen.mp4
Please make sure these boxes are checked before submitting your pull request - thanks!
[ X] Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anything[ X] If you have multiple commits please combine them into one commit by squashing them.