fix : Enhance Create Client to Align with development Branch #2426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
revanthkumarJ
force-pushed
the
client_create
branch
from
7069c27 to
4a5a2d3
Compare
revanthkumarJ
force-pushed
the
client_create
branch
from
0c35189 to
60a83de
Compare
Nagarjuna0033
suggested changes
Jul 5, 2025
core/database/src/commonMain/kotlin/com/mifos/room/entities/client/ClientPayloadEntity.kt
Outdated
Show resolved
Hide resolved
Nagarjuna0033
approved these changes
Jul 5, 2025
biplab1
approved these changes
Jul 5, 2025
There was a problem hiding this comment.
The changes look good to me. Some minor corrections are required, but this can be merged.
Could you please upload a screen recording after disabling the address in the web app’s system setup?
Also, the country and state are not related in the address fields (as was the case in the development branch). Can we add that in this PR, following the implementation in mobile-wallet: openMF/mobile-wallet#1872 — or should we handle it in a separate PR?
feature/client/src/commonMain/composeResources/values/strings.xml
Outdated
Show resolved
Hide resolved
revanthkumarJ
force-pushed
the
client_create
branch
from
986e266 to
f1543d0
Compare
|
@biplab1 when address enabled is false in configuration it won't show in app WhatsApp.Video.2025-07-06.at.10.07.05.AM.mp4 |
niyajali
approved these changes
Jul 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#486
Video uploaded to slack as it is more than 10 mb not allowed by github.
Video can be found at
https://mifos.slack.com/archives/C06FC73DZPW/p1751707308227149?thread_ts=1751706991.145709&cid=C06FC73DZPW
What achieved in this pr.
Regarding create client some changes are done in development branch which are not there in kmp-impl branch so added all those by refering below prs
feat(feature:client): add address fields to create client form (#2380) · openMF/android-client@b00bfe1
fix - Failed to fetch staffs in createNewClient screen (#2357) · openMF/android-client@2886200
fix: Can't create new client (#2358) · openMF/android-client@aa7576c