fix(feature:client): fix stuck loading & empty state for charges UI #2428
Conversation
biplab1
changed the title
|
Note:
|
|
@biplab1 can you upload the video to confirm the changes once |
biplab1
force-pushed
the
MIFOSAC-459-client-charges
branch
from
d49d242 to
210cc53
Compare
|
@niyajali Could you please reopen this PR? It mistakenly got closed. |
biplab1
force-pushed
the
MIFOSAC-459-client-charges
branch
from
085ed09 to
d32ca3f
Compare
| MifosPagingAppendProgress() | ||
| when (chargesPagingList.loadState.append) { | ||
| is LoadState.Error -> {} | ||
|
|
There was a problem hiding this comment.
when error occurs don't we need to show anything?
There was a problem hiding this comment.
Thanks for pointing that out! I've added MifosSweetError with an appropriate message.
| val code: String, | ||
| val name: String, | ||
| val decimalPlaces: Double, | ||
| val inMultiplesOf: Int, | ||
| val displaySymbol: String, | ||
| val nameCode: String, | ||
| val displayLabel: String, | ||
| val decimalPlaces: Double? = null, | ||
| val inMultiplesOf: Int? = null, |
There was a problem hiding this comment.
its always better to provide default values for fields, especially when the data class is used for network responses, give default values to code and name as well
There was a problem hiding this comment.
The name and code fields for Currency are required and non-nullable, so a default value shouldn’t be necessary.
There was a problem hiding this comment.
Update:
I’ve made code and name nullable in the Currency class to safely handle cases where no currency is set up in the web app, and to prevent potential crashes. Let me know if you’d like me to handle it differently.
biplab1
force-pushed
the
MIFOSAC-459-client-charges
branch
from
4bba406 to
3d1a8dc
Compare
|
@itsPronay @revanthkumarJ I have addressed all the comments you made. Please let me know if any further changes are needed. If everything looks good, kindly approve. |
Fixes - Jira-#459
Summary of changes:
@Serializableto all charge-related data classes to enable proper serialization/deserialization in API communication.collecttofirst()and handling empty DB results with a proper empty state UI1 July 2025instead of2025-7-1client-charges-loading-fix.webm
Charges List:
client-charges-direct-api-fetch.webm
Run the static analysis check
./gradlew checkorci-prepush.shto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.