-
Notifications
You must be signed in to change notification settings - Fork 489
Logout on Unauthorized access #1864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thank you for your efforts, here's few things we need to address, and let us know or mention me after you fix these we'll proceed with merge.
feature/auth/src/commonMain/kotlin/org/mifospay/feature/auth/AuthErrorDialog.kt
Outdated
Show resolved
Hide resolved
core/network/src/commonMain/kotlin/org/mifospay/core/network/utils/KtorInterceptor.kt
Outdated
Show resolved
Hide resolved
feature/auth/src/commonMain/kotlin/org/mifospay/feature/auth/AuthErrorDialog.kt
Outdated
Show resolved
Hide resolved
feature/auth/src/commonMain/kotlin/org/mifospay/feature/auth/AuthErrorDialog.kt
Outdated
Show resolved
Hide resolved
@niyajali I have made the suggested changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me can be merged, can you upload a video to demonstrate this functionality and work as expected. After that we'll proceed with merge.
For the video demonstration, i modified the header token to trigger the interceptor and get a HttpStatus.UNAUTHORIZED. |
mifospay-shared/src/commonMain/kotlin/org/mifospay/shared/MifosPayApp.kt
Outdated
Show resolved
Hide resolved
@Shreyash16b After watching the video that you've shared cancel button is unnecessary not good for UI/UX, remove it and only keep "Ok" button. |
Also update the dialog title and message with proper human understandable text. |
@niyajali I have made the required changes. |
@Shreyash16b Hi, Thanks for the PR, Did you joined our slack community if not join now(link in readme) and join our channel mifos-pay channel and if you would like to work on other tickets then let's us know on channel we'll assign some tickets. |
@niyajali Thank you, I have joined the slack channel and am assigned another ticket. |
Hi, that's great, but I suggest joining our daily standup and our project maintainer(Rajan Sir) will assign you some tickets which we're currently focusing on. |
Yes, I am attending the standup regularly and Rajan Sir has assigned tickets to me. |
Issue Fix
Jira Task: https://mifosforge.jira.com/browse/MW-206
Description
Video
LogoutUnauthorized.mp4
When an invalid token is present in the header the app asks user to login again.
Apply the
AndroidStyle.xml
style template to your code in Android Studio.[✅] Run the unit tests with
./gradlew check
to make sure you didn't break anything[✅] If you have multiple commits please combine them into one commit by squashing them.