-
Notifications
You must be signed in to change notification settings - Fork 520
fix(workflows): correct sync directory workflow for scheduled runs #1952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(workflows): correct sync directory workflow for scheduled runs #1952
Conversation
📝 WalkthroughWalkthroughThe PR modifies workflow and build configuration: adds a conditional gate preventing the sync job from running on the template repository itself, introduces an UPSTREAM environment variable with a default fallback, and removes the ktlint plugin declaration from Gradle configuration. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
b07059b to
85ec4aa
Compare
|
We need to copy the required modules and files from kmp template and lots of fixes are needed in sync script/workflow. |
|
So it's better not to worry about the workflows or any script, copy the mentioned directory and files accordingly and change the project specific files only based on this project |
|
@niyajali Yes, I understand your concern. Since the sync directories workflow in I have opened a separate PR for adding missing files from template. |
Issue Fix
Jira Task: MW-329
Screenshots
Description
Summary of changes:
upstreamaddress in shell command which was not being passed correctly during scheduled runsifstatement for skippingsync-dirsworkflow runs in thekmp-project-templateApply the
AndroidStyle.xmlstyle template to your code in Android Studio.Run the unit tests with
./gradlew checkto make sure you didn't break anythingIf you have multiple commits please combine them into one commit by squashing them.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.