Skip to content

Conversation

@biplab1
Copy link
Contributor

@biplab1 biplab1 commented Jan 6, 2026

Issue Fix

Jira Task: MW-329

Screenshots

Description

Summary of changes:

  • Added upstream address in shell command which was not being passed correctly during scheduled runs
  • Added if statement for skipping sync-dirs workflow runs in the kmp-project-template

  • Apply the AndroidStyle.xml style template to your code in Android Studio.

  • Run the unit tests with ./gradlew check to make sure you didn't break anything

  • If you have multiple commits please combine them into one commit by squashing them.

Summary by CodeRabbit

  • Chores
    • Enhanced workflow synchronization with repository-specific handling and improved upstream URL configuration with fallback support
    • Removed ktlint plugin from build configuration

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link

coderabbitai bot commented Jan 6, 2026

📝 Walkthrough

Walkthrough

The PR modifies workflow and build configuration: adds a conditional gate preventing the sync job from running on the template repository itself, introduces an UPSTREAM environment variable with a default fallback, and removes the ktlint plugin declaration from Gradle configuration.

Changes

Cohort / File(s) Summary
Workflow Configuration
.github/workflows/sync-dirs.yaml
Adds conditional gate (if: github.repository != 'openMF/kmp-project-template') to sync-directories job; introduces UPSTREAM environment variable with fallback to default repository URL; updates git remote command to use the new variable.
Build Configuration
build.gradle.kts
Removes alias(libs.plugins.ktlint) apply false from plugins block, eliminating ktlint plugin declaration.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A hop through workflows, so clean and refined,
The sync finds its boundary, a gate well-designed,
With fallbacks in place and defaults so true,
And ktlint removed—less noise, more to do!
A tidy little change that makes templates bright,
Hopping forward now, everything's right! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Title check ❓ Inconclusive The title mentions workflow corrections for scheduled runs but does not address the removal of ktlint plugin from build.gradle.kts, which is a significant part of the changeset. Either update the title to reflect all major changes (e.g., 'fix(workflows, build): correct sync directory workflow and remove ktlint plugin') or clarify if the ktlint removal is out of scope.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b07059b and 5995e76.

📒 Files selected for processing (2)
  • .github/workflows/sync-dirs.yaml
  • build.gradle.kts
💤 Files with no reviewable changes (1)
  • build.gradle.kts
🚧 Files skipped from review as they are similar to previous changes (1)
  • .github/workflows/sync-dirs.yaml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: PR Checks / Build iOS App
  • GitHub Check: PR Checks / Build Web Application

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@biplab1 biplab1 marked this pull request as draft January 6, 2026 13:24
@biplab1 biplab1 force-pushed the MW-329-fix-sync-dirs-for-auto-sync-with-template branch from b07059b to 85ec4aa Compare January 6, 2026 13:30
@niyajali
Copy link
Collaborator

niyajali commented Jan 6, 2026

We need to copy the required modules and files from kmp template and lots of fixes are needed in sync script/workflow.

@niyajali
Copy link
Collaborator

niyajali commented Jan 6, 2026

So it's better not to worry about the workflows or any script, copy the mentioned directory and files accordingly and change the project specific files only based on this project

@biplab1
Copy link
Contributor Author

biplab1 commented Jan 6, 2026

@niyajali Yes, I understand your concern. Since the sync directories workflow in kmp-project-template and mifos-mobile were fixed earlier for scheduled runs, so I raised this PR for this repo as well to keep the workflow in sync.

I have opened a separate PR for adding missing files from template.

@biplab1 biplab1 marked this pull request as ready for review January 6, 2026 17:14
@therajanmaurya therajanmaurya merged commit da9fc7c into openMF:development Jan 7, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants