-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarify species type extension #264
base: upcoming-2.0.0
Are you sure you want to change the base?
Conversation
Following discussion in #262 I replaced RFC 2119 terms (MUST, SHOULD NOT...) with bold text, but using lowercase. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you already!
I marked a few typos and will do a thorough review soon!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work done by everyone!
Co-authored-by: Axel Huebl <[email protected]>
If I read the openPMD validator correctly (do I?), currently only non-empty strings consisting of
|
I think that makes sense, if one uses the speices type extension then one should actually specify a |
This PR clarifies the species type extension, adds a full definition using ABNF.
Technically it introduces breaking changes -- for details, please see below.
Issues: #256 #257 #258 #259 #260 #261
Description
other:
is not allowed in lists, as to allow it the semicolon;
would have to be forbidden from its content.item1;;item2
), trailing separator optional.other:
other:
(without suffix) as well as trailing spaces -- even though they are allowed.In its entirety, this aims to clarify the current version of the standard.
Except for the treatment of
other:
, all unambiguous parts have been left untouched.Valid examples:
Invalid examples:
other:·
·
electron;;H
;;
Uux
H2O
Affected Components
EXT-SpeciesType
Logic Changes
other:
forbidden in listsWriter Changes
speciesType
sother:
Existing writers are compatible, as long as they
speciesType
Reader Changes
Lists with one item must be considered single particle species.
As molecules and ions have been explicitly forbidden, reader implementations are encouraged to specify their additionally accepted syntax explicitly.
(Which they should do anyways).
openPMD-validator
: https://github.com/openPMD/openPMD-validator/(I did not encounter any other mentions of
speciesType
in the related tools.)Data Converter
Not implemented, hence no changes necessary.