Refactor LifecycleFlag to help editors #54
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomschr
force-pushed
the
refactor-lifecycle
branch
from
2c3e6a3 to
c22ccd9
Compare
Dynamically created class didn't work well with VSCode and attribute access. * Use a real class * Remove BaseLifecycleFlag. It's not needed anymore * Use auto() to get integer value * Use only "unknown" in lowercase to avoid problems with iterating over the class
tomschr
force-pushed
the
refactor-lifecycle
branch
from
c22ccd9 to
86a8205
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamically created class didn't work well with VSCode and attribute access.
BaseLifecycleFlag. It's not needed anymoreauto()to get integer value