-
Notifications
You must be signed in to change notification settings - Fork 66
Ensure site works under Ruby 3.4.3 #254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update 5-year-old bundler version - Specify some dependencies that have been extracted out of Ruby - Update Liquid to compatible version
|
@tacerus we are still running under ruby 3.1 on the server side like in the Ci, right? |
063c77a to
5709803
Compare
|
Are you building the site again on a server? I see that you've already got a GitHub Actions generating the static assets. If that's easier on server end, I could ensure the static assets are exposed as artifacts in the GitHub workflow so they can be downloaded and deployed as-is on any Apache. Then you don't need to couple the build process to a specific Ruby version that runs on the server. Unrelated note: it looks like Rubygem's mirrors are currently unstable. I got |
|
Will be necessary to make it work with both versions then if you want to update the dependencies |
d31818f to
3b586d7
Compare
3b586d7 to
621db43
Compare
|
I've integrated the generation of the website assets into a GitHub action and made sure it uses a recent Ruby version. There are two ways to get the generated assets:
Would this work for you? |
|
Updated the main branch with support for both ruby 3.1 and 3.4 (tested both locally) 285346c |
I had trouble getting the site up and running locally. It seems the issues were related to dated dependencies.