Reduce usage of bareword file handles #1068
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not that I mind the change, as perl versions that don't support file handle autovivication are no longer supported by obs-build. But the change is actually a non-issue due to the |
|
(But I do not like the |
|
But this needs to be changed so that lowercase variable names are used. |
Barewords in Perl are package level and may be interpreted as subroutine calls if a subroutine with a name colliding with the file handle's name is declared in the package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Barewords in Perl are package level and may be interpreted as subroutine calls if a subroutine with a name colliding with the file handle's name is declared in the package.
This was one of the issues found via perlcritic by Radically Open Security.