Use fnmatch again for excludes #521
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the documentation, the value of the "excludes" parameter for obs_scm is a glob. But since commit 140a127 ("fix excludes for obscpio") the code treats this value as a regular expression, which leads to wrong matching results and may lead to python crashes if the glob expression starts with "*". Fixes: openSUSE#520 Fixes: 140a127 ("fix excludes for obscpio")
|
This PR breaks But this contradicts the documentation, and it breaks legitimate code. If matching by regular expression is desired, perhaps that could be achieved with some additional syntax, e.g. |
This was referenced May 28, 2025
|
Obsoleted by #525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the documentation, the value of the "excludes" parameter for obs_scm is a glob. But since commit 140a127 ("fix excludes for obscpio") the code treats this value as a regular expression, which leads to wrong matching results and may lead to python crashes if the glob expression starts with "*".
Fixes: #520
Fixes: 140a127 ("fix excludes for obscpio")