Skip to content

[archive] fix include/exclude glob to regex conversion #526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025

Conversation

M0ses
Copy link
Collaborator

@M0ses M0ses commented Jun 18, 2025

No description provided.

@M0ses
Copy link
Collaborator Author

M0ses commented Jun 18, 2025

@mwilck @olafhering

Please check this variant.

For the record:
IIRC I removed fnmatch because it did never work correctly.

@M0ses M0ses force-pushed the fix_exclude_include branch from b29d33b to cd531ee Compare June 18, 2025 13:41
@M0ses M0ses force-pushed the fix_exclude_include branch from cd531ee to 5b88ce3 Compare June 18, 2025 14:07
@mwilck
Copy link
Contributor

mwilck commented Jun 18, 2025

I wasn't quite certain how to test this locally. Here's what I did:

/usr/lib/obs/service/obs_scm --url https://github.com/openSUSE/suse-module-tools.git --scm git --changesgenerate enable --filename suse-module-tools --versionformat @PARENT_TAG@+@TAG_OFFSET@ --versionrewrite-pattern '([^+]*)\+0' --revision master --exclude '*.rpmlintrc' --outdir /tmp/x

This fails as reported previously.

Now I pulled the code from this PR into a local git repo and replaced the env python with /usr/bin/python3.11.

mwilck@apollon:suse-module-tools> /mnt/git/obs-service-tar_scm/obs_scm --url https://github.com/openSUSE/suse-module-tools.git --scm git --changesgenerate enable --filename suse-module-tools --versionformat @PARENT_TAG@+@TAG_OFFSET@ --versionrewrite-pattern '([^+]*)\+0' --revision master --exclude '*.rpmlintrc' --outdir /tmp/x
Cloning into '/tmp/x/tmpy2k_bmb1/suse-module-tools'...
db5c2837fc8f80349f9d29880158814feebbe52a
No changesauthor defined!
You can define it by:
 * configure 'email=' in ~/.config/osc/oscrc in your default api section
 * configure <param name="changesauthor">...</param> in your _service file
 * using '--changesauthor' on the cli

The previous error didn't occur. The exclude directive was correctly applied.

So basically this is looking good for my use case.

@M0ses M0ses merged commit beb511d into openSUSE:master Jun 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants