Only set the scmsync package for selected actions

Author: hellcp-work

src/api/app/controllers/webui/package_controller.rb

@@ -22,7 +22,11 @@ class Webui::PackageController < Webui::WebuiController
   before_action :set_package, only: %i[edit update show requests statistics revisions
                                        branch_diff_info rdiff remove
                                        save_person save_group remove_role view_file
-                                       buildresult rpmlint_result rpmlint_log rpmlint_summary files users]
+                                       buildresult rpmlint_result rpmlint_log rpmlint_summary files users],
+                              unless: -> { Flipper.enabled?(:scmsync, User.session) }
+  before_action :set_package_with_scmsync, only: %i[show revisions branch_diff_info rdiff view_file buildresult
+                                                    rpmlint_result rpmlint_log rpmlint_summary files users],
+                                           if: -> { Flipper.enabled?(:scmsync, User.session) }
   # rubocop:enable Rails/LexicallyScopedActionFilter
   before_action :lints_list, only: %i[rpmlint_summary]
 

src/api/app/controllers/webui/packages/binaries_controller.rb

@@ -14,7 +14,8 @@ class BinariesController < Webui::WebuiController
       before_action :require_login, except: [:index]
       before_action :set_project
       before_action :check_scmsync, unless: -> { Flipper.enabled?(:scmsync, User.session) }
-      before_action :set_package
+      before_action :set_package, unless: -> { Flipper.enabled?(:scmsync, User.session) }
+      before_action :set_package_with_scmsync, if: -> { Flipper.enabled?(:scmsync, User.session) }
       before_action :set_multibuild_flavor
       before_action :set_repository
       before_action :set_architecture, only: %i[show dependency filelist]

src/api/app/controllers/webui/packages/build_reason_controller.rb

@@ -5,7 +5,8 @@ class BuildReasonController < Webui::WebuiController
 
       before_action :set_project
       before_action :check_scmsync, unless: -> { Flipper.enabled?(:scmsync, User.session) }
-      before_action :set_package
+      before_action :set_package, unless: -> { Flipper.enabled?(:scmsync, User.session) }
+      before_action :set_package_with_scmsync, if: -> { Flipper.enabled?(:scmsync, User.session) }
       before_action :set_repository
       before_action :set_architecture
 

src/api/app/controllers/webui/packages/files_controller.rb

@@ -6,7 +6,8 @@ class FilesController < Webui::WebuiController
 
       before_action :set_project
       before_action :check_scmsync, only: :show, unless: -> { Flipper.enabled?(:scmsync, User.session) }
-      before_action :set_package
+      before_action :set_package, unless: -> { Flipper.enabled?(:scmsync, User.session) }
+      before_action :set_package_with_scmsync, if: -> { Flipper.enabled?(:scmsync, User.session) }
       before_action :set_filename, only: %i[show update destroy blame]
       before_action :ensure_existence, only: %i[show blame]
       before_action :ensure_viewable, only: %i[show blame]

src/api/app/controllers/webui/packages/job_history_controller.rb

@@ -5,7 +5,8 @@ class JobHistoryController < Webui::WebuiController
 
       before_action :set_project
       before_action :check_scmsync, unless: -> { Flipper.enabled?(:scmsync, User.session) }
-      before_action :set_package
+      before_action :set_package, unless: -> { Flipper.enabled?(:scmsync, User.session) }
+      before_action :set_package_with_scmsync, if: -> { Flipper.enabled?(:scmsync, User.session) }
       before_action :set_repository
       before_action :set_architecture
 

src/api/app/controllers/webui/packages/meta_controller.rb

@@ -4,7 +4,8 @@ class MetaController < Webui::WebuiController
       include ScmsyncChecker
 
       before_action :set_project
-      before_action :set_package
+      before_action :set_package, unless: -> { Flipper.enabled?(:scmsync, User.session) }
+      before_action :set_package_with_scmsync, if: -> { Flipper.enabled?(:scmsync, User.session) }
 
       before_action :check_scmsync, unless: -> { Flipper.enabled?(:scmsync, User.session) }
       before_action :validate_xml, only: :update

src/api/app/controllers/webui/repositories_controller.rb

@@ -5,7 +5,8 @@ class Webui::RepositoriesController < Webui::WebuiController
   before_action :check_scmsync, if: -> { params[:package] && !Flipper.enabled?(:scmsync, User.session) }
   before_action :set_repository, only: [:state]
   before_action :set_architectures, only: %i[index change_flag]
-  before_action :set_package, only: %i[index change_flag], if: -> { params[:package] }
+  before_action :set_package, only: %i[index change_flag], if: -> { params[:package] && !Flipper.enabled?(:scmsync, User.session) }
+  before_action :set_package_with_scmsync, only: %i[index change_flag], if: -> { params[:package] && Flipper.enabled?(:scmsync, User.session) }
   before_action :set_main_object, only: %i[index change_flag]
   before_action :check_ajax, only: :change_flag
   after_action :verify_authorized, except: %i[index state]

src/api/app/controllers/webui/webui_controller.rb

@@ -100,6 +100,19 @@ def set_package
 
     return if @package_name.blank?
 
+    begin
+      @package = Package.get_by_project_and_name(@project.name, @package_name, follow_multibuild: true)
+    # why it's not found is of no concern
+    rescue APIError
+      raise Package::UnknownObjectError, "Package not found: #{@project.name}/#{@package_name}"
+    end
+  end
+
+  def set_package_with_scmsync
+    @package_name = params[:package] || params[:package_name]
+
+    return if @package_name.blank?
+
     begin
       @package = Package.get_by_project_and_name(@project.name, @package_name,
                                                  follow_multibuild: true,