[api] Fix usage of scmsync projects via project links #18563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not enough to check only the project itself for scmsync otherwise permissions are checked on package A and execution is done on package B. Broke with 02afcf6 for scmsync which made this a special thing for scmsync, but it needs to work anyway in general as it does for remote packages. It means we would also need to duplicate all permission testing now. issue#18205
Member
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not enough to check only the project itself for scmsync otherwise permissions are checked on package A and execution is done on package B.
Broke with 02afcf6 for scmsync which made this a special thing for scmsync, but it needs to work anyway in general as it does for remote packages. It means we would also need to duplicate all permission testing now.
Fixes #18205
Related to #18522