Skip to content

Conversation

@danidoni
Copy link
Contributor

@danidoni danidoni commented Nov 5, 2025

No description provided.

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Nov 5, 2025
@@ -1,4 +1,5 @@
class AssignmentsController < ApplicationController
before_action :require_admin, only: %i[create destroy]
Copy link
Contributor

@krauselukas krauselukas Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danidoni I think the assignment policy should be used instead

collaborators can create/delete assignments as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I'll fix it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, looking at the policy, that uses this, looks like it allows to assign collaborators, that is not the same than allowing collaborators to assign someone else. I'm I right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I don't think you are right. You can create an assignment (assingn someone) if you have a relationship with the Project/Package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the policy is missing to authorize the assigner... that should be there IMO, talking to @hellcp-work

Copy link
Contributor Author

@danidoni danidoni Nov 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hennevogel alright, but what this policy is doing is assigning someone if that someone is a collaborator, am I reading it right? In other words, if the assignee is a collaborator, but what you say is that the assigner is a collaborator, that is not what this policy is doing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danidoni @hennevogel that should be the change that is required #18791

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend Things related to the OBS RoR app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants