Skip to content

Conversation

@Digvijay-x1
Copy link

@Digvijay-x1 Digvijay-x1 commented Nov 14, 2025

Hey Friends ,

I have redesign the Maintenance Label by changing its position and the style so that it can match the adjacent components .

Here is a screenshot of how it looks:

Before :

image

After :

Screenshot From 2025-11-14 18-44-37

Some additional changes -

  • I have updated the test in maintenance_incident.rb to expect the new text Maintenance Incident instead of the old text This is a Maintenance Incident, aligning it with the recent changes I made in _request_header.html.haml.

Fixes #18683

@github-actions github-actions bot added the Frontend Things related to the OBS RoR app label Nov 14, 2025
@Digvijay-x1
Copy link
Author

Hi, I think the CI build is failing because the test expects the old text . It looks like it expects: expect(page).to have_text('This is a Maintenance Incident') But it should now be: expect(page).to have_text('Maintenance Incident') . Can I update the test in maintenance_workflow_spec.rb to reflect this, or am I missing something ? Please let me know :)

@rubhanazeem
Copy link
Member

Thanks for opening the PR! Yes, please go ahead and fix the failing specs.

@Digvijay-x1
Copy link
Author

@rubhanazeem Thank you for your help . I have pushed some changes and I think it should resolve the remaining test related issues but if there are still some issues with the code please let me know .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Frontend Things related to the OBS RoR app

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request Maintenance Label

2 participants