Add presence validation to AttribValue position #18907
Draft
+8
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krauselukas
reviewed
Nov 27, 2025
Contributor
krauselukas
left a comment
krauselukas
left a comment
There was a problem hiding this comment.
@danidoni besides the failing tests it looks good to me
danidoni
force-pushed
the
add-presence-validation-to-attribvalue-position-field
branch
from
c6ef85c to
4aa8005
Compare
The position column is required in the database, but the model was missing the validation. This commit adds the validation to the model so the constraint is in sync.
danidoni
force-pushed
the
add-presence-validation-to-attribvalue-position-field
branch
from
4aa8005 to
b0f2a4c
Compare
Contributor
Author
I fixed them. Can you take a look again? |
Member
Now, both minitests and RSpec are failing... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The position column is required in the database, but the model was missing the validation. This commit adds the validation to the model so the constraint is in sync.