Notifications API: use show_maximum param for count #18912
Draft
+50
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... instead of using direct calls to `Backend::Connection`
Do not include detailed parser messages when the raised error is an `ArgumentError`. Keep showing detailed error information for all other previously handled exceptions.
... of a package instead of using direct calls to `Backend::Connection`
... instead of using direct calls to `Backend::Connection` Don't pass the `user` parameter to the backend. This backend endpoint has never accepted the `user` parameter. Adapt the specs to mock `Backend::Api::BuildResults::Binaries` instead of `Backend::Connection`.
... instead of using direct calls to `Backend::Connection`
If you pass show_maximum in the query, the API now returns up to that many notifications (capped at max_per_page). This fixes the mismatch between docs and code—before, it always used total. Also checked that state and kind filters work as expected. No more notifications_type in docs. See openSUSE#18910.
- Implement for /my/notifications. - Add specs for default behavior, limited results and capping at Notification.max_per_page. - Defensive filter handling and improved comments. Fixes openSUSE#18910.
geetxnshgoyal
force-pushed
the
fix-notifications-api-parameter-mismatch
branch
from
40c2af6 to
9df55f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
How to verify