Skip to content

Fix: Validate lastsuccess query param in BuildController #18913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+11 −1
Open

Fix: Validate lastsuccess query param in BuildController #18913

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bcd7f68
fix/issue#18891
piyusshkumar Nov 28, 2025
b37b078
Merge branch 'master' into restricting-queryparams
piyusshkumar Nov 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/api/app/controllers/build_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,17 @@ def logfile

def result
# this route is mainly for checking submissions to a target project
return result_lastsuccess if params.key?(:lastsuccess)
# allowed value are set to true/false or 1/0
if params.key?(:lastsuccess)
allowed_values = ["1", "0", "true", "false", 1, 0 , true, false]

unless allowed_values.include(params[:lastsuccess])
return render_error status:400,
errorcode: "invalid_lastsuccess_value",
message: "Parameter 'lastsuccess' must be true/false or 1/0"
end
return result_lastsuccess
end

# for permission check
Project.get_by_name(params[:project])
Expand Down