Fix CFP conference timezone

[nolleto]

Checklist

• I have read the Contribution & Best practices Guide.
• My branch is up-to-date with the upstream master branch.
• The tests pass locally with my changes.
• I have added tests that prove my fix is effective or that my feature works(if appropriate).
• I have added necessary documentation (if appropriate).

Short description of what this resolves/which issues does this fix?:

• Update cfp.open? to consider the conference timezone.
• Issue CFP open check should respect conference timezone #2769

Changes proposed in this pull request:

• Now, the CFP will check the conference timezone to verify if it's open or not.

[hennevogel]

Hey @nolleto thanks for this fix! 😃

[hennevogel]

Looks like you have to fix the model spec. I guess changing Time.zone isn't the best idea, maybe in_time_zone?

[hennevogel]

let me know if you need help @nolleto

[nolleto]

Sorry for the delay. I will update with in_time_zone today

[nolleto]

Looks like you have to fix the model spec. I guess changing Time.zone isn't the best idea, maybe in_time_zone?

I think using in_time_zone will not work...

Time.zone = timezone_plus14
Timecop.freeze(Time.zone.now)
# VS
Timecop.freeze(Time.zone.now.in_time_zone(timezone_plus14))

Because I need the server and the cfp.program.conference.timezone be in a different timezone and executing Timecop.freeze(Time.zone.now.in_time_zone(timezone_plus14)) will not change the server time zone 🤔

So, I added an after to reset the server timezone to default

  describe '#open?' do
    let!(:server_timezone) { Time.zone }
    let(:timezone_plus14) { 'Pacific/Apia' }
    let(:timezone_plus14) { 'Pacific/Apia' }

    after do
      Time.zone = server_timezone
    end
  ...

But, if you have a better idea, just let me know :)