Json ld finetune 1 #558
Merged
Json ld finetune 1 #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomschr
force-pushed
the
json-ld-finetune-1
branch
2 times, most recently
from
6201e75
to
dce9222
Compare
* JSON-LD: Rewrite author + authorgroup code
* Simplify code and create a two set approach
* If no (author/editor/corpauthor/contributor)s or authorgroup is
found, fallback to a default corporation author
* Add new parameters:
- json-ld-fallback-author-name: The author's name
- json-ld-fallback-author-url: the author's URL
- json-ld-fallback-author-type: "Corporation" by default
(but can also be a "Person")
- json-ld-fallback-author-logo: the URL pointing to the logo
* Correct metadata
* Rename abstract -> description and refactor code
* Introduce "sameAs" property
* Disable json-ld-version and json-ld-keywords
* Use "Corporation" instead of "Organization" for default author
and publisher
tomschr
force-pushed
the
json-ld-finetune-1
branch
from
dce9222
to
5a77718
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
Correct metadata
"abstract"->"description"and refactor code"sameAs"propertyjson-ld-versionandjson-ld-keywordsJSON-LD: Rewrite
author+authorgroupcodeauthor/editor/corpauthor/contributor)s orauthorgroupisfound, fallback to a default corporation author
json-ld-fallback-author-name: The author's namejson-ld-fallback-author-url: the author's URLjson-ld-fallback-author-type: "Corporation" by default(but can also be a "Person")
json-ld-fallback-author-logo: the URL pointing to the logo