Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style.css - right-nav changes #573

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Conversation

GGayathri3
Copy link
Contributor

Modified the right-nav styling on article pages

Modified the right-nav styling on article pages
@GGayathri3 GGayathri3 self-assigned this Sep 11, 2023
Copy link
Collaborator

@tomschr tomschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GGayathri3 Thanks Gayathri, that looks great!

Maybe one small wish/idea: when I click one entries on the left sidebar, the text turns into a bold(ish) font type. However, that is hardly distinguishable (see picture).

Would it help if we use a different background (same as text body) for the selected item? Or maybe change text color?

Screenshot_20230911_083753

Other than that, it looks great! 👍

@tomschr tomschr marked this pull request as draft September 11, 2023 07:49
@tomschr
Copy link
Collaborator

tomschr commented Sep 11, 2023

@GGayathri3 I was wrong, my previous comment targeted the left sidebar, not the right one. Ignore that for the time being.

Apart from the changes, try to move them into the SASS file(s). I searched a bit and found for your rules these files:

  • main #_side-toc-page
    file custom/major-elements.sass, line 133.

  • .side-toc .side-title, .side-toc a, .side-toc .toc a:focus, .side-toc .toc a:hover, .side-toc .toc a:active
    file custom/side-toc.sass

  • main article
    file custom/major-elements.sass, line 98

  • .article h1.title
    file custom/content-title.sass, maybe you need to add a new rule.

Maybe there are better files, but from a quick look it seems okay.

Hope that help. 🙂

@tomschr tomschr added format-html html, xhtml, html5, webhelp, jsp support skill-css/js CSS and/or Javascript knowledge necessary styles-2022 "suse2022-ns" styles topic-smartdocs For SmartDocs labels Sep 11, 2023
@tomschr tomschr marked this pull request as ready for review September 18, 2023 07:13
@tomschr tomschr merged commit c51b27b into main Sep 18, 2023
2 checks passed
@tomschr tomschr deleted the Right-nav-styling-style.css branch September 18, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format-html html, xhtml, html5, webhelp, jsp support skill-css/js CSS and/or Javascript knowledge necessary styles-2022 "suse2022-ns" styles topic-smartdocs For SmartDocs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants