Fix handling of external JSON-LD generation #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implementation had an issue with $rootid set and wasn't reliable. This is corrected now. Additionally, this commit changes: * Add language into external JSON-LD filename * Take into account rootid parameter for filename * Enable JSON-LD structure for HTML by default
|
Frank tested it and he said it's fine. Many thanks! 👍 |
tomschr
added a commit
that referenced
this pull request
Mar 25, 2024
There were two "about" keys before: one for "Thing" and another for "WebPage". This created a validation issue. This fix bring them together in one "about" property.
tomschr
added a commit
that referenced
this pull request
Mar 25, 2024
Fix #617: Put task and webpage both into "about"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some DC files didn't create the JSON-LD structure. This fix should get around it.
This PR contains:
concat($json-ld-base.dir, $lang, '-', $filename)