Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release readiness review (v0.9.3 -> TARGET 10e5ad3)
This is a release readiness report done by
$final-release-reviewskill.Diff
v0.9.3...10e5ad3
Release call:
🟢 GREEN LIGHT TO SHIP Patch-level change with targeted tests and docs updates; no concrete blockers identified.
Scope summary:
src/agents/tracing/processors.py), trace processor tests, docs (including translated), version bump inpyproject.tomlanduv.lock.Risk assessment (ordered by impact):
Tracing usage payload reshaping
usage.detailsfor OpenAI trace ingest; if any downstream consumer relied on top-levelinput_tokens_details/output_tokens_details, they will no longer appear in the ingested payload.BackendSpanExporter._sanitize_for_openai_tracing_apinow calls_sanitize_generation_usage_for_openai_tracing_apiand moves unsupported usage keys into adetailssub-dict; tests updated accordingly. Commit:02e8b03d.src/agents/tracing/processors.py,tests/test_trace_processor.pyuv run pytest -k trace_processorand confirm all trace sanitization tests pass (expect updateddetailsshape).Usage dropped when required token counts are invalid
input_tokens/output_tokensare non-finite or missing, usage is removed entirely for trace ingest; this is stricter than before and could reduce telemetry for malformed inputs._is_finite_json_numberand usage-drop behavior when token counts are invalid inprocessors.py; new tests explicitly verify drop behavior.src/agents/tracing/processors.py,tests/test_trace_processor.pyinput_tokens/output_tokensto ensure usage is preserved.Notes:
git tag -l 'v*' --sort=-v:refname | head -n1→v0.9.3.HEAD10e5ad3ee98208ff61a3f0a8d2a2af6d7ee013b6.$code-change-verificationper repository policy.