feat: add env to disable debug log #1222
Open
+6
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| typeof process !== 'undefined' && | ||
| typeof process?.env?.['OPENAI_DISABLE_DEBUG'] !== 'string' && | ||
| process?.env?.['DEBUG'] === 'true' | ||
| ) { |
There was a problem hiding this comment.
Can we simplify the condition by avoiding redundant optional chaining (?.) on process.env.
if (
typeof process !== 'undefined' &&
process?.env &&
typeof process.env['OPENAI_DISABLE_DEBUG'] !== 'string' &&
process.env['DEBUG'] === 'true'
) {
There was a problem hiding this comment.
We could!
However, I won't be making any more changes until I hear from a collaborator on whether or not this PR or a change like it would be merged.
Thanks
|
Can this be merged please? The solution has already been presented months ago. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Adds the ability to completely disable debug logging.
This is a stopgap, if I was requesting an actual fix it would be to implement an inversion of control, and enable the user of this sdk to specify the logger, that way this flag becomes unnecessary. This simple workaround is more than enough for my needs.
Additional context & links
#302