Add progress callback to transcribe function and corresponding test #2625
+35
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed this functionality for a project and decided to implement it in here instead of reading stdout. This commit adds a new parameter
progress_callbackthat updates every loop (similar to the progress bar) and passes in the percent completed to the callback.To test this, I also added a longer file
fdr.mp3(trying to fit the theme) and a test that runs whisper with a progress callback that dumps all the values to an array. It does 2 simple checks: if the array is longer than 0 and if the last value is 100.0.