Explicitly set boundary for multipart/form-data #1005
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actual Behavior
When an endpoint only has one body type, which is
multipart/form-data
, theContent-Type
header is not set, so that HTTPX can set it with the correct boundary.However, when an endpoint has multiple body types, the
Content-Type
header is always set, and HTTPX do not override it, which results in a missing boundary formultipart/form-data
body types (resulting in a400 - Bad Request
response from the servers).Proposed Changes
Let's always set the boundary to
+++
to avoid any potential problem.NB: This is kind of related to #1004, since in my specific case, the
multipart/form-data
body type is the last, it is always the one that is used.