Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional features #722

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

lee-elenbaas
Copy link
Contributor

@lee-elenbaas lee-elenbaas commented Feb 1, 2023

I added the additional features i needed from other forks along with one more feature that i needed into this fork

  1. Ability to pass target path instead of chdir to the path first
  2. Ability to access full endpoint information from within the templates
  3. Ability to override and control the location of each endpoint independantly of the tag
  4. Ability to raise exception for failed responses - failed responses by default are in the range [200, 300) - and can be explicitly set to be success or failure using the x-response-type property (can be one of: auto, success, failure)
  5. Supports optional x-focus-path to create sync_focused/asincio_focused functions that target directly a specific path inside the parsed response
  6. Supports additional optional template per endpoint for utility functions that wil be added to the generated module
    Path to this optional template can be controlled independantly, and template can be linked per endpoint using x-utility-functions-template attribute

@dbanty
Copy link
Collaborator

dbanty commented Mar 28, 2023

This PR will have to be split up into one-per-significant-change so that our changelog generation & versioning can function properly—that will also make it easier to figure out if some of these fixes/features are duplicates of other PRs. That's not to say that anyone involved so far needs to do this, just that it will have to happen before the changes merge. I need to update the contributing guidelines to make that more clear, right now it just vaguely mentions conventional commits 😞

@lee-elenbaas
Copy link
Contributor Author

@dbanty i will create separate PR for the features i worked on - but not for the features i pulled from other forks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants