Skip to content

Feature/jakarta #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Conversation

dgautier
Copy link

Fix #116 , #109 , #48
Merges #121

CarstenWickner and others added 26 commits January 2, 2024 21:36
Bumps [metcalfc/changelog-generator](https://github.com/metcalfc/changelog-generator) from 4.3.0 to 4.3.1.
- [Release notes](https://github.com/metcalfc/changelog-generator/releases)
- [Changelog](https://github.com/metcalfc/changelog-generator/blob/main/release-notes.png)
- [Commits](metcalfc/changelog-generator@v4.3.0...v4.3.1)

---
updated-dependencies:
- dependency-name: metcalfc/changelog-generator
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [com.google.guava:guava](https://github.com/google/guava) from 30.0-jre to 32.0.0-jre.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps `org.slf4j.version` from 1.7.29 to 2.0.12.

Updates `org.slf4j:slf4j-api` from 1.7.29 to 2.0.12

Updates `org.slf4j:slf4j-simple` from 1.7.29 to 2.0.12

---
updated-dependencies:
- dependency-name: org.slf4j:slf4j-api
  dependency-type: direct:production
  update-type: version-update:semver-major
- dependency-name: org.slf4j:slf4j-simple
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps `org.apache.maven.version` from 3.6.0 to 3.9.6.

Updates `org.apache.maven:maven-plugin-api` from 3.6.0 to 3.9.6
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-3.6.0...maven-3.9.6)

Updates `org.apache.maven:maven-core` from 3.6.0 to 3.9.6
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-3.6.0...maven-3.9.6)

Updates `org.apache.maven:maven-artifact` from 3.6.0 to 3.9.6
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-3.6.0...maven-3.9.6)

Updates `org.apache.maven:maven-compat` from 3.6.0 to 3.9.6
- [Release notes](https://github.com/apache/maven/releases)
- [Commits](apache/maven@maven-3.6.0...maven-3.9.6)

---
updated-dependencies:
- dependency-name: org.apache.maven:maven-plugin-api
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.maven:maven-core
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.maven:maven-artifact
  dependency-type: direct:production
  update-type: version-update:semver-minor
- dependency-name: org.apache.maven:maven-compat
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
…c/changelog-generator-4.3.1

Bump metcalfc/changelog-generator from 4.3.0 to 4.3.1
…-guava-32.0.0-jre

Bump com.google.guava:guava from 30.0-jre to 32.0.0-jre
Bumps commons-fileupload:commons-fileupload from 1.4 to 1.5.

---
updated-dependencies:
- dependency-name: commons-fileupload:commons-fileupload
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [com.google.guava:guava](https://github.com/google/guava) from 30.0-jre to 33.0.0-jre.
- [Release notes](https://github.com/google/guava/releases)
- [Commits](https://github.com/google/guava/commits)

---
updated-dependencies:
- dependency-name: com.google.guava:guava
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
…n-2.0.12

Bump org.slf4j.version from 1.7.29 to 2.0.12
….version-3.9.6

Bump org.apache.maven.version from 3.6.0 to 3.9.6
…-guava-33.0.0-jre

Bump com.google.guava:guava from 30.0-jre to 33.0.0-jre
Bumps the maven group group with 1 update: [com.fasterxml.jackson.core:jackson-databind](https://github.com/FasterXML/jackson).


Updates `com.fasterxml.jackson.core:jackson-databind` from 2.12.2 to 2.12.7.1
- [Commits](https://github.com/FasterXML/jackson/commits)

---
updated-dependencies:
- dependency-name: com.fasterxml.jackson.core:jackson-databind
  dependency-type: direct:production
  dependency-group: maven-security-group
...

Signed-off-by: dependabot[bot] <[email protected]>
…/commons-fileupload-commons-fileupload-1.5

Bump commons-fileupload:commons-fileupload from 1.4 to 1.5 in /src/it/ISSUE-25
…group-320b313540

Bump the maven group group with 1 update
feat: replace reflections lib with classgraph from @CarstenWickner
@mali30
Copy link

mali30 commented Apr 7, 2024

Any idea on when this PR is going to get merged. This is blocking me from upgrading to java17 and spring boot 3 due to jakarta/javax. Please let me know friend @dgautier. Tagging @langecode also.

@dgautier
Copy link
Author

dgautier commented Apr 8, 2024

Hi, @mali30 , I did released the fork i worked on to unblock myself as well, you can use it if you want : https://central.sonatype.com/artifact/io.github.dgautier/swagger-maven-plugin

@mali30
Copy link

mali30 commented Apr 8, 2024

Hi, @mali30 , I did released the fork i worked on to unblock myself as well, you can use it if you want : https://central.sonatype.com/artifact/io.github.dgautier/swagger-maven-plugin

Im pulling this repo from a nexus repository and the only way I can use it for my app is if this PR gets merged to the repo. It would be great if @langecode could get this merged ASAP.

@htr3n
Copy link

htr3n commented Apr 24, 2024

I don't know if the main dev has time to merge, but even so, it's not possible or does not make sense to merge if the PR contains a different combo of groupId/artifactId. To officially merge the changes into this repo, I suppose the groupId/artifactId must remain the same.

@solomax
Copy link

solomax commented Jan 4, 2025

Hi, @mali30 , I did released the fork i worked on to unblock myself as well, you can use it if you want : https://central.sonatype.com/artifact/io.github.dgautier/swagger-maven-plugin

Hello @dgautier
I just tried your fork and it seems to fail at our project (with the same error as reported here #109)
Am I right thinking #109 should be fixed in this fork? :))

@in-fke
Copy link

in-fke commented Mar 25, 2025

Guys, move to Jakarta!

@in-fke
Copy link

in-fke commented Mar 25, 2025

Hi, @mali30 , I did released the fork i worked on to unblock myself as well, you can use it if you want : https://central.sonatype.com/artifact/io.github.dgautier/swagger-maven-plugin

I thought this was supporting Jakarta- but I am getting the same error

[ERROR] Failed to execute goal io.github.dgautier:swagger-maven-plugin:2.0.0:generate (default) on project de.ingmbh.aaa.service: Execution default of goal io.github.dgauti
er:swagger-maven-plugin:2.0.0:generate failed: Cannot invoke "java.util.Map.size()" because "map" is null -> [Help 1]

@dgautier
Copy link
Author

Hi,

Sadly it seems this project isn't maintained anymore.

It's been a while since i moved on to other projects, could you provide a reproducer ? I may found some time to fix it on my fork.

@in-fke
Copy link

in-fke commented Mar 31, 2025

Sadly it seems this project isn't maintained anymore.

That would actually be sad. Other Plugins don't honor the Swagger Annotations (as far as I know).

Actually, I found two drawbacks that smallrye-open-api-maven-plugin would have (any more alternatives?)

  1. does not honor the Swagger @operation annotation with it's attribute "operationId"
  2. does not preserve the generic type argument for Lists etc., e.g., for reflecing something like List<User> findUsers()

It's been a while since i moved on to other projects, could you provide a reproducer ?

Probably not - maybe I'd rather fork you fork and try to go from there. Where is your fork? (I could not find it on short notice)

@langecode
Copy link
Member

I really appreciate people using the project. Sadly I do not have the time to maintain the library here - as I am not using this nor Java in my day-to-day work anymore.

I tried putting a little effort into reviving the project last summer (#124) - put it takes more time that I have on my hands unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot invoke "java.util.Map.size()" because "map" is null
8 participants