Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix middleware docs #1976

Merged
merged 3 commits into from
Oct 30, 2024
Merged

Fix middleware docs #1976

merged 3 commits into from
Oct 30, 2024

Conversation

jo-m
Copy link
Contributor

@jo-m jo-m commented Oct 30, 2024

Changes

Fix throwing middleware example in docs

Fixes #1954

How to Review

Doc change only.

Checklist

  • Unit tests updated
  • docs/ updated (if necessary)
  • pnpm run update:examples run (only applicable for openapi-typescript)

@jo-m jo-m requested a review from a team as a code owner October 30, 2024 08:23
Copy link

changeset-bot bot commented Oct 30, 2024

⚠️ No Changeset found

Latest commit: 65a03b0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🙏

@drwpow drwpow merged commit ff57082 into openapi-ts:main Oct 30, 2024
8 checks passed
@drwpow
Copy link
Contributor

drwpow commented Oct 30, 2024

Probably need to look into some way to not add that changeset comment for docs-only changes. Sorry for the noise there. And thanks for your first contribution! Much appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The throwing middleware implementation available in the documentation is not working
2 participants