Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] adding legacy CSS for info-buttons #415

Open
wants to merge 1 commit into
base: release_9
Choose a base branch
from

Conversation

chfsx
Copy link
Contributor

@chfsx chfsx commented Mar 7, 2025

This fixes the issue described in #389 . we have to introduce some own CSS for the moment.

@dagraf
Copy link

dagraf commented Mar 7, 2025

@reiferschris: Since you reported the bug (#389) fixed with this PR, can you please test this PR and report your findings here? Thx!

@reiferschris
Copy link
Contributor

Unfortunately I can't see a change. The css is loaded and appears in the events.css file, so no caching issue.

@dagraf dagraf added To discuss Needs discussion with the community and removed To discuss Needs discussion with the community labels Mar 11, 2025
@marcusm7
Copy link

marcusm7 commented Mar 13, 2025

Doesn't work for me either. Ilias9 + Plugin: /fix/9/389

The browser (most recent Firefox) shows:
image

The changes events.css is loaded (dev-tools -> network tab):
image

@dagraf
Copy link

dagraf commented Mar 18, 2025

@chfsx: Two tester still observe problems here (see above). Can you please have a look at this? Thx!

@marcusm7
Copy link

@chfsx For completeness I would like to add that the 'Beitreten'-Button for Livestream-Publications has the same problem. It is displayed as Text-Link like 'Abspielen'.

@chfsx
Copy link
Contributor Author

chfsx commented Mar 20, 2025

I now updated the PR accordingly... My browser was a bit more gracious, the CSS was simply invalid, please excuse!
FYI: the branch was rebased/force-pushed. If you have any questions about how to check out again, please let me know.

@dagraf
Copy link

dagraf commented Mar 20, 2025

@reiferschris: Since you reported the bug (#389) fixed with this PR, can you please re-test this PR and report your findings here? Thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Testing
Development

Successfully merging this pull request may close these issues.

None yet

4 participants