Skip to content

Conversation

@Arnei
Copy link
Member

@Arnei Arnei commented May 30, 2024

Adds a hotkey (Shift+Alt+e) to the subtitle editor. It allows the user to add a new subtitle segment, based on the current time of the video.

Resolves #1313.

Adds a hotkey (Shift+Alt+e) that allows the
user to add a new subtitle segment at the
current point on the timeline.
@Arnei Arnei added the type:enhancement New feature or request label May 30, 2024
@github-actions
Copy link

This pull request is deployed at test.editor.opencast.org/1367/2024-05-30_14-08-36/ .
It might take a few minutes for it to become available.

@snoesberger
Copy link
Contributor

Thanks for that. There is one small issue, every time I use a keyboard shortcut to add a subtitle segment, the special character corresponding to the shortcut is added to the new segment. I would expect it to just add a new empty segment.

This is not only true for Shift+Alt+e but also for Shift+Alt+q and Shift+Alt+a.

@github-actions github-actions bot added the status:conflicts Conflicts with another pull request or issue label Dec 17, 2024
@github-actions
Copy link

This pull request has conflicts ☹
Please resolve those so we can review the pull request.
Thanks.

@github-actions github-actions bot removed the status:conflicts Conflicts with another pull request or issue label Dec 17, 2024
@github-actions
Copy link

This pull request is deployed at test.editor.opencast.org/1367/2024-12-17_08-19-18/ .
It might take a few minutes for it to become available.

@geichelberger
Copy link
Contributor

@snoesberger I could not reproduce it. Is it still an issue for you?

@snoesberger
Copy link
Contributor

@snoesberger I could not reproduce it. Is it still an issue for you?

Yes, it is still a problem, I just tried again. It depends on the keyboard language you are using. If you're using a standard German keyboard layout (de), you won't see the problem. With a Swiss-German (de-ch) or US layout I'm able to reproduce the problem in different browsers.

@gregorydlogan gregorydlogan changed the base branch from develop to r/17.x May 21, 2025 20:54
@gregorydlogan gregorydlogan self-assigned this Aug 7, 2025
@gregorydlogan gregorydlogan merged commit d659be5 into opencast:r/17.x Aug 7, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type:enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Subtitle editor: insert a new subtitle segment at the current playtime

4 participants