Make absinthe_plug an optional runtime dependency #14
Conversation
Per: https://github.com/opencensus-beam/opencensus_absinthe/pull/13/files#r290670529 This resolves a race condition at compile-time. See upstream PR here: opencensus-beam#13
Codecov Report
@@ Coverage Diff @@
## master #14 +/- ##
=========================================
- Coverage 28.94% 28.2% -0.75%
=========================================
Files 6 7 +1
Lines 38 39 +1
=========================================
Hits 11 11
- Misses 27 28 +1
Continue to review full report at Codecov.
|
…s called to prevent errors with precompiled queries
|
I went ahead and lumped in my changes for #15 into this PR. If it makes anybody upset, I can rebase/cherry pick as necessary. |
|
I'd like to keep these separate, yes. |
|
I've split the race condition from PR #13 into PR #16. @lytedev, please:
|
| |> Opencensus.Absinthe.add_phases() | ||
| |> Absinthe.Plug.default_pipeline(pipeline_opts) |
There was a problem hiding this comment.
Did this work? If so, the Absinthe documentation might need some work. The documentation for Absinthe.Plug/default_pipeline/2 says it takes a map and a keyword list and returns a pipeline, i.e. a list of phases…
There was a problem hiding this comment.
Did this work? If so, the Absinthe documentation might need some work. The documentation for
Absinthe.Plug/default_pipeline/2says it takes a map and a keyword list and returns a pipeline, i.e. a list of phases…
Probably not. As you say, this looks like I have lines 31 and 32 in the wrong order. 🤦♂
Nice catch!
Per:
https://github.com/opencensus-beam/opencensus_absinthe/pull/13/files#r290670529
This resolves a race condition at compile-time. See upstream PR here:
#13