Skip to content

feat/initial-v initial v#1

Merged
hminaee-tc merged 3 commits intomainfrom
feat/initial-v
Jun 19, 2024
Merged

feat/initial-v initial v#1
hminaee-tc merged 3 commits intomainfrom
feat/initial-v

Conversation

@hminaee-tc
Copy link
Contributor

@hminaee-tc hminaee-tc commented Jun 19, 2024

Changes proposed in this PR:

  • Initial code for pre-commit hooks

  • git work flow to also publish it as a PYPI

  • extra cautionary pre commit hook to check the published version and complain if already exists

    • fail on existing v
    • fail on not committed toml file if v has changed
  • E2E

  • OIDC

  • unit test

  • Extra features

  • verbose

    • log-level
    • h
    • usage
    • dry-run

@hminaee-tc hminaee-tc requested a review from andreouellet June 19, 2024 20:34
Copy link
Contributor

@andreouellet andreouellet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hminaee-tc hminaee-tc merged commit e53f801 into main Jun 19, 2024
@hminaee-tc hminaee-tc deleted the feat/initial-v branch June 19, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants