Skip to content

add site apis checks #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 16, 2025
Merged

add site apis checks #270

merged 5 commits into from
Jul 16, 2025

Conversation

peterdudfield
Copy link
Contributor

@peterdudfield peterdudfield commented Jul 16, 2025

Pull Request

Description

Add site checks api
Both for UK and India

#272
#271

How Has This Been Tested?

  • CI test
  • tested it on dev

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield marked this pull request as ready for review July 16, 2025 12:31
@peterdudfield peterdudfield requested a review from devsjc July 16, 2025 12:31
Copy link
Contributor

@devsjc devsjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change the name of the files to be "check-" instead? I've been putting the type of dag at the start so its easier to parse groupings. Also, is this duplicating behaviour in betteruptime?

@peterdudfield
Copy link
Contributor Author

Can you change the name of the files to be "check-" instead? I've been putting the type of dag at the start so its easier to parse groupings. Also, is this duplicating behaviour in betteruptime?

The very first check is duplicate betteruptime, but the fine checks like, is there a generation for that site, is not check in uptime.

@peterdudfield peterdudfield merged commit 3e75115 into main Jul 16, 2025
4 checks passed
@peterdudfield peterdudfield deleted the api-site-checks branch July 16, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants