Skip to content

Update slack.py by Adding Function (#268) #275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 17, 2025

Conversation

peterdudfield
Copy link
Contributor

  • Update slack.py

Add counrty flag to slack no action requireed

  • Update Slack failure callback in consume-runvnl-dag

Replaces the static Slack failure callback with a dynamic callback using get_slack_message_callback_no_action_required('in') for improved configurability.

  • Remove unused slack_message_callback_no_action_required import

Cleaned up the imports in consume-runvnl-dag.py by removing the unused slack_message_callback_no_action_required import. This helps maintain code clarity and avoids unnecessary imports.

  • Update slack.py

removing unnecessary lines

  • Refactor Slack callback message formatting

Improved the formatting of the Slack notification message in get_slack_message_callback_no_action_required for better readability. Also standardized string quotes in consume-runvnl-dag.py and removed unnecessary whitespace.


Pull Request

Description

Please delete the italicised instruction text!
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
Please also list any relevant details for your test configuration

  • Yes

If your changes affect data processing, have you plotted any changes? i.e. have you done a quick sanity check?

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

* Update slack.py

Add counrty flag to slack no action requireed

* Update Slack failure callback in consume-runvnl-dag

Replaces the static Slack failure callback with a dynamic callback using get_slack_message_callback_no_action_required('in') for improved configurability.

* Remove unused slack_message_callback_no_action_required import

Cleaned up the imports in consume-runvnl-dag.py by removing the unused slack_message_callback_no_action_required import. This helps maintain code clarity and avoids unnecessary imports.

* Update slack.py

removing unnecessary lines

* Refactor Slack callback message formatting

Improved the formatting of the Slack notification message in get_slack_message_callback_no_action_required for better readability. Also standardized string quotes in consume-runvnl-dag.py and removed unnecessary whitespace.

---------

Co-authored-by: Peter Dudfield <[email protected]>
@peterdudfield peterdudfield marked this pull request as ready for review July 17, 2025 18:50
@peterdudfield peterdudfield merged commit bbcbb76 into main Jul 17, 2025
4 checks passed
@peterdudfield peterdudfield deleted the dynamic-slack-message-flag branch July 17, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants