Updated the TCAM for invalid IPv6 test validation.

[keysightgems]

Readme Location: https://github.com/openconfig/featureprofiles/blob/main/feature/urpf/otg_tests/urpf_vrf_test/README.md

Find the attached logs here: https://partnerissuetracker.corp.google.com/u/1/issues/415458482

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the testing infrastructure for Unicast Reverse Path Forwarding (URPF) by introducing specific hardware configurations for validating invalid IPv6 traffic. The changes streamline the device under test (DUT) initialization process and integrate a comprehensive TCAM profile to accurately simulate and test egress IPv6 URPF scenarios.

Highlights

• Refactored Hardware Initialization: The configureHardwareInit function was updated to use a more generic loop for applying hardware initialization features, specifically enabling FeatureEgressIPv6URPF.
• Introduced Egress IPv6 URPF Feature: A new FeatureEgressIPv6URPF constant was added to represent the specific hardware configuration for Egress IPv6 Unicast Reverse Path Forwarding.
• Defined Arista TCAM Profile for Egress IPv6 URPF: A detailed Arista TCAM profile (aristaTcamEgressIPv6URPF) was added, encompassing various ACL, QoS, and forwarding rules tailored for IPv6 URPF validation.

Changelog

• feature/urpf/otg_tests/urpf_vrf_test/urpf_vrf_test.go
  • Modified the configureHardwareInit function to dynamically apply hardware initialization features, specifically targeting FeatureEgressIPv6URPF.
  • Removed direct calls for FeatureVrfSelectionExtended and FeaturePolicyForwarding initialization.
• internal/cfgplugins/dut_initialize.go
  • Defined a new FeatureEgressIPv6URPF constant to categorize the specific URPF hardware configuration.
  • Added a new string constant, aristaTcamEgressIPv6URPF, which contains the Arista-specific TCAM profile configuration for egress IPv6 URPF, including ACLs, QoS, and forwarding rules.
  • Updated the aristaHardwareInitMap to associate FeatureEgressIPv6URPF with its corresponding TCAM configuration string.

Activity

• The author has provided links to attached logs for further review and analysis of the test validation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[OpenConfigBot]

Pull Request Functional Test Report for #5188 / e993d36

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		URPF-1.1: uRPF validation from non-default network-instance
Cisco 8000E		URPF-1.1: uRPF validation from non-default network-instance
Cisco XRd		URPF-1.1: uRPF validation from non-default network-instance
Juniper ncPTX		URPF-1.1: uRPF validation from non-default network-instance
Nokia SR Linux		URPF-1.1: uRPF validation from non-default network-instance
Openconfig Lemming		URPF-1.1: uRPF validation from non-default network-instance

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		URPF-1.1: uRPF validation from non-default network-instance
Cisco 8808		URPF-1.1: uRPF validation from non-default network-instance
Juniper PTX10008		URPF-1.1: uRPF validation from non-default network-instance
Nokia 7250 IXR-10e		URPF-1.1: uRPF validation from non-default network-instance

Help

[gemini-code-assist]

Code Review

The pull request successfully introduces a new FeatureEgressIPv6URPF and its corresponding Arista TCAM profile, with the changes in internal/cfgplugins/dut_initialize.go being correctly implemented. A critical issue was identified in feature/urpf/otg_tests/urpf_vrf_test/urpf_vrf_test.go where the configureHardwareInit function was modified to remove the configuration for FeatureVrfSelectionExtended and FeaturePolicyForwarding. This contradicts the function's description and could lead to functional regressions if the test relies on these features. This comment is retained as it does not conflict with any provided rules.