configurable grpc buffer #727
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LimeHat
suggested changes
Sep 11, 2025
Comment on lines
+54
to
+55
| defaultWriteBufSize = 32 * 1024 | ||
| defaultReadBufSize = 32 * 1024 |
There was a problem hiding this comment.
remove, no need to override golang defaults
| a.RootCmd.PersistentFlags().StringArrayVarP(&a.Config.GlobalFlags.Exclude, "exclude", "", nil, "YANG module names to be excluded") | ||
|
|
||
| a.RootCmd.PersistentFlags().UintVarP(&a.Config.GlobalFlags.TargetGRPCWriteBufferSize, "target-grpc-write-buffer-size", "", defaultWriteBufSize, "gRPC write buffer size for the target connection") | ||
| a.RootCmd.PersistentFlags().UintVarP(&a.Config.GlobalFlags.TrgetGRPCReadBufferSize, "target-grpc-read-buffer-size", "", defaultReadBufSize, "gRPC read buffer size for the target connection") |
There was a problem hiding this comment.
do you need a global flag for this? not everything has to be exposed as an argument. this can be a config file only option.
but if you do, use int and -1 as the default value.
also, there's typo in the word target (&a.Config.GlobalFlags.TrgetGRPCReadBufferSize)
| Subscriptions []string `mapstructure:"subscriptions,omitempty" yaml:"subscriptions,omitempty" json:"subscriptions,omitempty"` | ||
| Outputs []string `mapstructure:"outputs,omitempty" yaml:"outputs,omitempty" json:"outputs,omitempty"` | ||
| BufferSize uint `mapstructure:"buffer-size,omitempty" yaml:"buffer-size,omitempty" json:"buffer-size,omitempty"` | ||
| GRPCReadBufferSize uint `mapstructure:"grpc-read-buffer-size,omitempty" yaml:"grpc-read-buffer-size,omitempty" json:"grpc-read-buffer-size,omitempty"` |
| })) | ||
| } | ||
| // Read write Buffer size, every value of type uint is >= 0 | ||
| tOpts = append(tOpts, grpc.WithReadBufferSize(int(tc.GRPCReadBufferSize))) |
There was a problem hiding this comment.
add a non-nil check after adding the pointer to the struct;
if you decide to keep the global argument with the new default (-1) - also add a non-negative check instead of int(uint) conversion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.