-
Notifications
You must be signed in to change notification settings - Fork 672
uRPF through another VRF OC proposal #1320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
Co-authored-by: Darren Loher <[email protected]>
/gcbrun |
No major YANG version changes in commit b1145b8 |
In concept this LGTM. It should be rebased to be compatible with #1307 which should merge in the next day or so. Also, please update the "Change Scope" with a description of the change. |
/gcbrun |
Done |
/gcbrun |
/gcbrun |
Co-authored-by: Darren Loher <[email protected]>
/gcbrun |
Will review at July 1, 2025 OC Operators meeting. Setting last call for July 8th |
Discussed at the July 1st OC Operators Meeting-- Sounds good to me. |
/gcbrun |
Hi, From Cisco, we would like a little more time to review this model internally as uRPF is generally expected to run on the network instance associated with the interface. |
Sounds reasonable. We can delay last call by a week for now and if we need more time, we can revisit. - OC Operators Meeting July 8th. |
@akvasu This is scheduled to merge today-- any last comments here? |
Request one more week to review feasibility of this OC model |
Thank you @Tavneet-Sidhu13 , I have extended the last call to July 23, 2025 |
Since the urpf-lookup-network-instance is part of the subinterface container, should we assume the interface will be associated with the defined VRFs, or will it remain part of the default VRFs? Also, please hold off on merging for one more week. We need a little more time to analyze this. |
This model proposal allows for any combination to cross VRF/NI boundaries and would imply the opposite. The subinterface this is set on is not a member of the target NI used for lookup (otherwise the tagged NI would be redundant and unnecessary) |
@@ -1307,6 +1314,14 @@ revision "2023-06-30" { | |||
LPMs to any path in the RIB, even if it is not selected for forwarding in the | |||
FIB."; | |||
} | |||
leaf urpf-lookup-network-instance { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: No need to repeat urpf-
here as this already falls under a urpf container
"If populated, this leaf provides the name of the network instance | ||
used to look up a packet's source address. When this leaf is | ||
omitted and uRPF is enabled, the packet's source address is looked | ||
up in the forwarding network-instance."; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
up in the forwarding network-instance."; | |
up in the network-instance in which this interface is a member of."; |
Change Scope
Platform Implementations