Skip to content

Add an enum value of EXCLUDE to the mpls-hop-type #1322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 22, 2025

Conversation

RyoheiFukui
Copy link
Contributor

@RyoheiFukui RyoheiFukui commented Jun 24, 2025

Change Scope

  • Add an enum value of EXCLUDE to the mpls-hop-type under the mpls-te model
  • This change is backwards compatible.

Users may specify the exclude address in explicit path specification for RSVP-TE LSP setup.

The configuration in Cisco shows the following

explicit-path name PATH1
 index 1 exclude-address ipv4 unicast 172.16.0.2

interface tunnel-te1
 destination 2.2.2.2
 path-option 10 explicit name PATH1
 path-option 20 dynamic

Given that several vendors' native YANG models are closely aligned with the description in EXRS (RFC4874 Sec.4.1)

Platform Implementations

dnRouter# configure
dnRouter(cfg)# protocols
dnRouter(cfg-protocols) # rsvp
dnRouter(cfg-protocols-rsvp)# explicit-path PATH_1
dnRouter(cfg-protocols-rsvp-expl-path)# index 1 ipv4-address 192.168.3.2 include-strict
dnRouter(cfg-protocols-rsvp-expl-path)# index 2 ipv4-address 192.168.3.3 include-strict
dnRouter(cfg-protocols-rsvp-expl-path)# index 3 ipv4-address 192.168.3.4 include-loose
dnRouter(cfg-protocols-rsvp-expl-path)# index 4 ipv4-address 192.168.3.5 exclude

@dplore
Copy link
Member

dplore commented Jun 24, 2025

/gcbrun

@OpenConfigBot
Copy link

OpenConfigBot commented Jun 24, 2025

No major YANG version changes in commit 4fbb2db

@dplore
Copy link
Member

dplore commented Jun 24, 2025

This seems ok from a model point of view. We will need at least one more vendor reference when you are ready before it can be approved.

@dplore
Copy link
Member

dplore commented Jun 24, 2025

FYI: I did find this Arista EOS command:
switch(config-te-rsvp-path-dyn-MyPath)# hop 10.0.56.6 exclude
Reference: https://www.arista.com/en/um-eos/eos-rsvp-te-commands#reference_vjp_cmq_w2c

@RyoheiFukui RyoheiFukui marked this pull request as ready for review June 27, 2025 07:48
@RyoheiFukui RyoheiFukui requested a review from a team as a code owner June 27, 2025 07:48
@RyoheiFukui
Copy link
Contributor Author

FYI: I did find this Arista EOS command: switch(config-te-rsvp-path-dyn-MyPath)# hop 10.0.56.6 exclude Reference: https://www.arista.com/en/um-eos/eos-rsvp-te-commands#reference_vjp_cmq_w2c

@dplore
I added vendor implementation and corrected syntax errors. Could you execute /gcbrun?

@dplore
Copy link
Member

dplore commented Jun 27, 2025

/gcbrun

@dplore
Copy link
Member

dplore commented Jul 8, 2025

/gcbrun

@dplore dplore moved this from Ready to discuss to last-call in OC Operator Review Jul 8, 2025
@dplore
Copy link
Member

dplore commented Jul 8, 2025

Reviewed in July 8th OC Operators meeting (APAC timezone). This is now last call for comments and will be merged on July 22, 2025

@ElodinLaarz ElodinLaarz merged commit eeed733 into openconfig:master Jul 22, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: last-call
Development

Successfully merging this pull request may close these issues.

4 participants