Skip to content

Add next-hop-group to local-routing-network-instance. #1325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 2, 2025

Conversation

dplore
Copy link
Member

@dplore dplore commented Jul 1, 2025

Change Scope

This is a follow up to #1324, refactoring of yang model groupings for openconfig-local-routing. This moves the static/next-hop-group grouping into the local-routing-network-instances module, allowing it to be reusable in modules that do not include network-instances.

No paths are changed, just the module in which they are contained.

         |     +--rw static-routes
         |     |  +--rw static* [prefix]
         |     |     +--rw prefix            -> ../config/prefix
         |     |     +--rw config
         |     |     |  +--rw prefix?        inet:ip-prefix
         |     |     |  +--rw set-tag?       oc-pt:tag-type
         |     |     |  +--rw description?   string
         |     |     +--ro state
         |     |     |  +--ro prefix?        inet:ip-prefix
         |     |     |  +--ro set-tag?       oc-pt:tag-type
         |     |     |  +--ro description?   string
-        |     |     +--rw next-hop-group
+        |     |     +--rw oc-loc-rt-netinst:next-hop-group
        |     |        +--rw oc-loc-rt-netinst:config
-        |     |     |  |  +--rw name?   -> /network-instances/network-instance/static/next-hop-groups/next-hop-group/name
+        |     |        |  +--rw oc-loc-rt-netinst:name?   -> ../../../../../../../oc-ni:static/next-hop-groups/next-hop-group/config/name
        |     |        +--ro oc-loc-rt-netinst:state
-        |     |     |  |  +--rw name?   -> /network-instances/network-instance/static/next-hop-groups/next-hop-group/name
+        |     |        |  +--rw oc-loc-rt-netinst:name?   -> ../../../../../../../oc-ni:static/next-hop-groups/next-hop-group/config/name

@OpenConfigBot
Copy link

OpenConfigBot commented Jul 1, 2025

Major YANG version changes in commit 301eb3c:
openconfig-local-routing.yang: 3.0.0 -> 4.0.0

@dplore dplore marked this pull request as ready for review July 1, 2025 20:53
@dplore dplore requested a review from a team as a code owner July 1, 2025 20:53
@dplore dplore requested a review from robshakir July 1, 2025 22:45
@dplore dplore moved this to In Progress in OC Operator Review Jul 2, 2025
@ghananigans
Copy link

ghananigans commented Jul 2, 2025

To confirm, is this a breaking change for the overall OC model?

I see the previous change wasn't considered a breaking change, but this change had the breaking label.

@dplore
Copy link
Member Author

dplore commented Jul 2, 2025

To confirm, is this a breaking change for the overall OC model?

I see the previous change wasn't considered a breaking change, but this change had the breaking label.

This change is in the same category. We make a breaking change in the OC models and reflect that in the yang module versions. But the OC Release will not have breaking changes because the leaves we broke were not yet present in any OpenConfig public release. The forthcoming OC public release will only increment v5.2.0 to v5.3.0.

@dplore dplore merged commit c424e01 into master Jul 2, 2025
14 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to last-call in OC Operator Review Jul 2, 2025
@dplore dplore deleted the dplore/local-routing-nhg-cfg branch July 2, 2025 22:30
@dplore dplore restored the dplore/local-routing-nhg-cfg branch July 8, 2025 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants