-
Notifications
You must be signed in to change notification settings - Fork 672
Add NAT model #1335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add NAT model #1335
Conversation
/gcbrun |
No major YANG version changes in commit 78ed184 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @nleiva for this contribution! I've only done a very shallow review so far of the general tree structure so far, but please consider using when statements and or descriptions instead of the choice statement.
"Number of ports allocated per mapping"; | ||
} | ||
|
||
choice traffic-matcher { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OC style strongly prefers to avoid choice statements, but you could use when for enforcing some validations in the model. (So far we have not used choice
in any OC model)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dplore, that was an oversight on our end. We replaced choice
with when
statements.
/gcbrun |
1 similar comment
/gcbrun |
Discussed in the OC Operators Meeting on July 15th. If we don't have a reason to use multiple implementations, we should try to choose a single means of configuration to help with vendor-neutral implementations. If we do actually have operational use cases for needing both ways of implementation, then this is fine. Sounds like ACL-based is supported by two vendors already; so, we may choose to only add the model for that subtree. |
Hi @dplore , would you trigger the cloud checks again? I believe we fixed the failing test. Thanks |
/gcbrun |
Change Scope
We use NAT instances to stay in line with RFC 8512.
NAT rules can match a
routing-policy
oracl-set
to accommodate different vendor implementations.Platform Implementations