-
Notifications
You must be signed in to change notification settings - Fork 672
mark transceiver serial-no and vendor-part as deprecated #1340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
mark transceiver serial-no and vendor-part as deprecated #1340
Conversation
/gcbrun |
No major YANG version changes in commit 27e943e |
/gcbrun |
You included a single vendor in your initial comment, and usually it helps to have more than one vendor to show neutrality? In this case, it's probably fine since the leaves exist in the model. You mention a different leaf in your initial comment than the one you list in the description, though? Do we want to distinguish / add a comment about this vs. |
I'm only aware of this one vendor, but I figured since this involves marking something as deprecating and not actually yet removing anything that this would be ok. @ElodinLaarz Could you please elaborate on your concern on distinguishing the two serial-no leaves? Do you mean add a note to |
Change Scope
This change is backwards compatible.
This change is marking the
components/component/transceiver/state/serial-no
andcomponents/component/transceiver/state/vendor-part
leaves as deprecated. Thecomponents/component/state/serial-no
andcomponents/component/state/part-no
leaves should be used instead going forward.These duplicate serial and part number leaves are duplicate/redundant, and the top-level component one is preferred.
Platform Implementations
nvidia has hardware that is using the
components/component/transceiver/state/serial-no
andcomponents/component/transceiver/state/vendor-part
instead ofcomponents/component/state/serial-no
andcomponents/component/state/part-no
.