Skip to content

mark transceiver serial-no and vendor-part as deprecated #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

SydneyCaulfeild
Copy link
Contributor

@SydneyCaulfeild SydneyCaulfeild commented Jul 18, 2025

Change Scope

This change is backwards compatible.

This change is marking the components/component/transceiver/state/serial-no and components/component/transceiver/state/vendor-part leaves as deprecated. The components/component/state/serial-no and components/component/state/part-no leaves should be used instead going forward.

These duplicate serial and part number leaves are duplicate/redundant, and the top-level component one is preferred.

Platform Implementations

nvidia has hardware that is using the components/component/transceiver/state/serial-no and components/component/transceiver/state/vendor-part instead of components/component/state/serial-no and components/component/state/part-no.

@dplore
Copy link
Member

dplore commented Jul 18, 2025

/gcbrun

@OpenConfigBot
Copy link

OpenConfigBot commented Jul 18, 2025

No major YANG version changes in commit 27e943e

@ElodinLaarz
Copy link
Contributor

/gcbrun

@ElodinLaarz
Copy link
Contributor

You included a single vendor in your initial comment, and usually it helps to have more than one vendor to show neutrality? In this case, it's probably fine since the leaves exist in the model.

You mention a different leaf in your initial comment than the one you list in the description, though? components/component/state/serial-no vs. transceiver/state/serial-no (which I assume is /components/component/transceiver/state/serial-no.)

Do we want to distinguish / add a comment about this vs. /components/component/state/serial-no?

@SydneyCaulfeild
Copy link
Contributor Author

SydneyCaulfeild commented Jul 21, 2025

You included a single vendor in your initial comment, and usually it helps to have more than one vendor to show neutrality? In this case, it's probably fine since the leaves exist in the model.

You mention a different leaf in your initial comment than the one you list in the description, though? components/component/state/serial-no vs. transceiver/state/serial-no (which I assume is /components/component/transceiver/state/serial-no.)

Do we want to distinguish / add a comment about this vs. /components/component/state/serial-no?

I'm only aware of this one vendor, but I figured since this involves marking something as deprecating and not actually yet removing anything that this would be ok.

@ElodinLaarz Could you please elaborate on your concern on distinguishing the two serial-no leaves? Do you mean add a note to /components/component/transceiver/state/serial-no in the .yang to explain that it is just a duplicate of components/component/state/serial-no? Or cleaning up the PR description?

@dplore dplore moved this to Ready to discuss in OC Operator Review Jul 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready to discuss
Development

Successfully merging this pull request may close these issues.

4 participants