Add OverrideLeafList support in ygot diff. #1046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented handling for DeleteWithUpdateLeafList operation in diff.go Added corresponding test cases in diff_test.go Tested locally to ensure correct functionality and pushed the generated Diff config in Arista FakeFabric (Google Internal Tool). Details: Explicitly delete and then update leaf-list, which is different and exists in both orig and modified. For example, if the original path is x/y/[a, b] and the modified leaf-list is x/y/[b, c], Then resulting notification will contain: Delete x/y/[a, b] Update x/y/[b, c] If this is false, then the leaf-list will be updated directly to the new value without the delete step. This is required because if the leaf-list is updated directly, the resulting notification will be: Update x/y/[b, c] This will cause the new value to be appended in the OC, but the original value will still be present in the OC. Resultant OC in the device will be x/y/[a, b, c].
aayueshbarui
changed the title
robshakir
reviewed
Aug 18, 2025
robshakir
reviewed
Aug 27, 2025
robshakir
reviewed
Aug 29, 2025
robshakir
reviewed
Aug 29, 2025
robshakir
reviewed
Aug 29, 2025
robshakir
requested changes
Aug 29, 2025
robshakir
reviewed
Sep 2, 2025
robshakir
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented handling for OverrideLeafList operation in diff.go Added corresponding test cases in diff_test.go
Tested locally to ensure correct functionality and pushed the generated Diff config in Arista FakeFabric (Google Internal Tool).
Details:
Explicitly delete and then update leaf-list, which is different and exists in both orig and modified. For example, if the original path is x/y/[a, b] and the modified leaf-list is x/y/[b, c], Then resulting notification will contain:
Delete x/y
Update x/y/[b, c]
If this is false, then the leaf-list will be updated directly to the new value without the delete step.