-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update GitHub Actions packages to resolve warnings in CI #1165
Update GitHub Actions packages to resolve warnings in CI #1165
Conversation
It looks like CI is failing due to linter version not being pinned for 1.20. Will see if I can open another PR to address. |
Opened #1167 to resolve CI issues. |
I guess this is ready for a rebase? 👀 |
71a16a9
to
c6246dd
Compare
Hmm, the issue with actions/upload-artifacts@v4 seems to stem from the breaking change documented in https://github.com/actions/upload-artifact:
I could try 'overwrite: true' however that also means the documentation could be created by different workflow runs. e.g. Go 1.19, 1.20, 1.21. Perhaps it would be best to revert this change for now and handle separately. |
This change updates actions/checkout to v4 and actions/setup-go to v5 to resolve NodeJS 16 deprecation warnings in CI. Signed-off-by: Austin Vazquez <[email protected]>
c6246dd
to
4da0cfc
Compare
I can push a separate fix for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Issue:
N/A
Description:
This change updates actions/checkout to v4 and actions/setup-go to v5 to resolve NodeJS 16 deprecation warnings in CI.
Before:
Additional References: