runtime: fail when a poststop hook fails #1265
Open
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abel-von
requested review from
AkihiroSuda,
crosbymichael,
cyphar,
dqminh,
giuseppe,
hqhq,
kolyshkin,
mrunalp,
thaJeztah,
tianon and
utam0k
as code owners
If a poststop hook run failed(maybe because the resource is still not ready to be recycled), we expect that the delete operation could fail and be retried util all poststop hooks run succeed. Signed-off-by: Abel Feng <[email protected]>
|
after this change poststop hooks are now required to be idempotent, even existing ones, as they can be called multiple times. Won't existing hooks fail in most cases when called multiple times. Possibly they can misbehave and remove the wrong resources. I wonder if this behavior should be configurable to not affect existing installations. We could have a flag for each hook to say whether a failure should be ignored or reported immediately (with the default being |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a poststop hook run failed(maybe because the resource is still not ready to be recycled), we expect that the delete operation could fail and be retried util all poststop hooks run succeed.
In the current runtime spec, when a
poststophook failed, runtime can not get the error, so that docker or kubernetes also can not get the error, this is easy to leave the resource residual.I think this is similar to the situation of
poststarthook. #1262Also please refer to the PR in runc:
opencontainers/runc#4364