rename Table to SummaryTable #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...because there are separate tables for the narratives.
afeld
force-pushed
the
summary-tables-C
branch
from
33208b7 to
8ccbcee
Compare
| "regexp" | ||
| "strings" | ||
| "fmt" | ||
|
|
||
| "github.com/jbowtie/gokogiri/xml" |
There was a problem hiding this comment.
FYI that this is go-plus making these kinds of changes automatically. I'm not quite that OCD 😉
There was a problem hiding this comment.
lol!! No worries. go-plus is running go fmt after every save. side note: we probably need to activate this for add this to our codeclimate rules: https://github.com/codeclimate-community/codeclimate-gofmt
|
just a few comments. looks good! |
afeld
force-pushed
the
summary-tables-C
branch
from
d451c7b to
a92ad09
Compare
Makes it easier to read.
jcscottiii
force-pushed
the
summary-tables-C
branch
from
364b82c to
3965568
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also did a little refactoring, and added a test. Broken out from #29.